Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overseer with lidarr support #3800

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

ano0002
Copy link

@ano0002 ano0002 commented Mar 3, 2024

Description

Implemented Lidarr Support into overseerr

Here is a sample docker-compose.yml for it :

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 5055:5055
    volumes:
      - .:/app:rw,cached
      - /app/node_modules
      - /app/.next

.gitignore Outdated Show resolved Hide resolved
@ano0002 ano0002 force-pushed the overseer-with-lidarr-support branch from 2e7f050 to 078c8b0 Compare April 6, 2024 14:36
@ano0002 ano0002 requested a review from samwiseg0 as a code owner April 6, 2024 14:36
@ano0002
Copy link
Author

ano0002 commented Apr 6, 2024

I just rebased all the commits, it's all in your hands now !

Added some fields I missed in the migration file and fixed some image
display issue
…nly a <Link>

Ported Links to work for the new React version installed
…maps to await them

I changed mapMovieResult and other equivalents to return Promises and forgot to fix some API
endpoints. So that's fixed now.
@githubaccount3322
Copy link

brilliant, hope this gets approved

@ano0002
Copy link
Author

ano0002 commented Jun 4, 2024

I'll repost here what I said on discord:

I temporarly pushed it to docker hub for anyone wanting to try it out but who don't want to build it: https://hub.docker.com/r/ano002/overseerr-lidarr
I'll delete it as soon as it gets merged.

And also:

Now that I'm using only the lidarr overseerr I found some bugs:

  • the Jobs & Cache page crashes in settings
  • even though they are in the backend I forgot to add the possibility change music quotas etc for users in the frontend

If you have found any other issues please report them to me

@ano0002
Copy link
Author

ano0002 commented Jun 18, 2024

the Jobs & Cache page crashes in settings

Just fixed this

@ano0002
Copy link
Author

ano0002 commented Jun 18, 2024

Even though they are in the backend I forgot to add the possibility change music quotas etc for users in the frontend

Fixed this too

@ano0002
Copy link
Author

ano0002 commented Aug 16, 2024

Thank you, @ano0002, for your hard work. I've found another bug: accessing Overseerr via HTTPS results in the following error:

[blocked] The page at https://overseerr.domain.com/ requested insecure content from http://IP:PORT/MediaCover/396/poster.jpg?lastWrite=ID. This content was blocked and must be served over HTTPS.

However, it works relatively fine when accessed via HTTP. Specifically, the artist posters are displayed correctly using HTTP when an artist page is opened but not on the music page.

Thanks for reporting that, I was aware of the issue and didn't have time to fix it yet. Will fix when I have time.

For any issues that arise could you please put them in: https://github.com/ano0002/overseerr/issues as it will make it easier to keep track

Since I was previously using an outdated version of Lidarr, my API calls were not functionnal with
the latest versions I updated and fixed them.
I've had to simply not set `album.artist.addOptions.monitor` at all and it works...

fix #9
@ano0002 ano0002 force-pushed the overseer-with-lidarr-support branch from 183e221 to c105f10 Compare August 18, 2024 19:58
@ano0002
Copy link
Author

ano0002 commented Aug 18, 2024

The Lidarr API should now work as expected (at least to add stuff, the scanning part hasn't changed)

@ano0002
Copy link
Author

ano0002 commented Aug 18, 2024

Pushed the latest commit to docker

@ano0002
Copy link
Author

ano0002 commented Aug 18, 2024

!!!
If you are using the lidarr fork and have been experiencing issue with the lidarr requests please pull the latest image from docker for both lidarr and overseerr-lidarr. I finally managed to find a fix which is reliable. The scans however might still have issues as I haven't gotten around to it yet.

@kieraneglin
Copy link

Tremendous work here! Is there any specific areas of testing that you'd like to give extra attention?

@ano0002
Copy link
Author

ano0002 commented Aug 27, 2024

I haven't fixed the lidarr scan and the UI requesting elements from lidarr directly so not those. But requesting should work for both artists and releases, artist are not always marked as available though. I also don't really know how I should make the search work, rn I'm not satisfied with how it works. I think there isn't anything specifically but if you find new bugs feel free to report them.

@ano0002 ano0002 force-pushed the overseer-with-lidarr-support branch from 56af105 to 6c07d22 Compare August 31, 2024 16:50
@Druidblack
Copy link

Druidblack commented Sep 14, 2024

Good afternoon. I want to see how the integration with ldap works, I'm trying to run docker. It gives an error when starting. What should I do to launch the docker container?

yarn run v1.22.19
error Couldn't find a package.json file in "/app"
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@ano0002
Copy link
Author

ano0002 commented Sep 17, 2024

Good afternoon. I want to see how the integration with ldap works, I'm trying to run docker. It gives an error when starting. What should I do to launch the docker container?

yarn run v1.22.19
error Couldn't find a package.json file in "/app"
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

What does your docker compose look like ?

@Druidblack
Copy link

Druidblack commented Sep 17, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /app/node_modules
      - /app/.next

@ano0002
Copy link
Author

ano0002 commented Sep 17, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /app/node_modules
      - /app/.next

You haven't mapped anything to /app

@Druidblack
Copy link

Druidblack commented Sep 17, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /srv/config/overseerrlidarr:/app/node_modules
      - /srv/config/overseerrlidarr:/app/.next

yarn run v1.22.19
error Couldn't find a package.json file in "/app"
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I've mapped all the folders. The error about missing files is still preserved.

@zolakk
Copy link

zolakk commented Sep 27, 2024

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /srv/config/overseerrlidarr:/app/node_modules
      - /srv/config/overseerrlidarr:/app/.next

yarn run v1.22.19 error Couldn't find a package.json file in "/app" info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I've mapped all the folders. The error about missing files is still preserved.

I had the same problem and switching from bind mount to docker volumes fixed it. It appears that for whatever reason (permissions?) this is one that just won't work correctly with bind mounts unless you want to pre-download everything into your mount folder first. I had the same issue with the emqx docker too and just gave up on fighting that one after many days of fighting it.

@ano0002
Copy link
Author

ano0002 commented Sep 30, 2024

Pushed a new build to docker with some fixes

@Gauvino
Copy link
Contributor

Gauvino commented Sep 30, 2024

First of all thanks for all the job you done @ano0002.
I have some question please:

  1. Why still having the PR in draft since it's ready to deploy now no other work needs to be done to it other than bug fix.
  2. Are you planning to add this change on jellyseerr?

@ano0002
Copy link
Author

ano0002 commented Sep 30, 2024

First of all thanks for all the job you done @ano0002.
I have some question please:

  1. Why still having the PR in draft since it's ready to deploy now no other work needs to be done to it other than bug fix.
  2. Are you planning to add this change on jellyseerr?
  1. I expect to have a fork with fewer bugs to deploy and merge it. However you can use the docker image I host if you can't wait and/or want to help me track bugs.

  2. No, I'm not using it and adding it to Overseerr already took a long time so no

@jbishop123
Copy link

I am new to the whole docker ecosystem. Currently using Unraid. I did the docker pull and then docker run. How do I get the apps linked so music shows up in Overseerr? Any help would be greatly appreciated!

@nhatlinh1982
Copy link

version: '3'
services:
  overseerr:
    build:
      context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
      args:
        COMMIT_TAG: c105f10420049d1ade2eb28a6ae8335e96507e74
      dockerfile: Dockerfile.local
    ports:
      - 6165:5055
    volumes:
      - /srv/config/overseerrlidarr:/app:rw,cached
      - /srv/config/overseerrlidarr:/app/node_modules
      - /srv/config/overseerrlidarr:/app/.next

yarn run v1.22.19 error Couldn't find a package.json file in "/app" info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
I've mapped all the folders. The error about missing files is still preserved.

I had the same problem and switching from bind mount to docker volumes fixed it. It appears that for whatever reason (permissions?) this is one that just won't work correctly with bind mounts unless you want to pre-download everything into your mount folder first. I had the same issue with the emqx docker too and just gave up on fighting that one after many days of fighting it.

While I appreciate you pointed to the solution, alot of us here are clueless to how to mount to docker volumes. I ask chatGPT for help and this solved the issue:

version: '3'
services:
overseerr:
build:
context: https://github.com/ano0002/overseerr.git#overseer-with-lidarr-support
args:
COMMIT_TAG: c105f10
dockerfile: Dockerfile.local
ports:
- 6165:5055
volumes:
- overseerr_config:/app
- overseerr_node_modules:/app/node_modules
- overseerr_next:/app/.next

volumes:
overseerr_config:
overseerr_node_modules:
overseerr_next:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.